#12012: 'make distclean' should clean up start.log, spkg/parallel_make.cfg
--------------------------------+-------------------------------------------
   Reporter:  jhpalmieri        |          Owner:  GeorgSWeber    
       Type:  defect            |         Status:  positive_review
   Priority:  blocker           |      Milestone:  sage-4.8       
  Component:  build             |       Keywords:                 
Work_issues:                    |       Upstream:  N/A            
   Reviewer:  Michael Orlitzky  |         Author:  John Palmieri  
     Merged:                    |   Dependencies:  #11991, #11959 
--------------------------------+-------------------------------------------
Changes (by mjo):

  * status:  needs_review => positive_review
  * reviewer:  => Michael Orlitzky


Comment:

 Replying to [comment:8 jhpalmieri]:
 >
 > I don't think I understand your question.  The point of the patch here
 is that if you download a Sage source distribution and run `make
 distclean`, it breaks the distribution: the Sage root repository is no
 longer clean, and more importantly, if you have no `$DOT_SAGE` directory,
 then when you build and run Sage, it will fail when it tries to create
 `DOT_SAGE/ipython/`.

 Oh, sorry. I thought the ipython directory would be recreated after a
 build, and I had to `make distclean` and then sit through a full rebuild
 to see that's not the case.

 I have reviewed:

 1. Confirm that spkg/parallel_make.cfg gets created/used in the following:

    * spkg/install
    * spkg/standard/deps

 2. Confirm that start.log should be removed.

 3. `make distclean`. Remove my ~/.sage directory. Build and try to start
 sage. Crashes per the ticket.


 So, looks good.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12012#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to