#12144: better document a technical confusing point in the Hidden Markov Model 
code
---------------------------+------------------------------------------------
   Reporter:  was          |          Owner:  amhou       
       Type:  enhancement  |         Status:  needs_review
   Priority:  minor        |      Milestone:  sage-4.8    
  Component:  statistics   |       Keywords:              
Work_issues:               |       Upstream:  N/A         
   Reviewer:               |         Author:              
     Merged:               |   Dependencies:              
---------------------------+------------------------------------------------
Changes (by was):

  * status:  needs_work => needs_review


Old description:

> I was reading the Continuous Hidden Markov Model code and trying to
> understand how probabilities are defined in a certain context, and got
> confused.   So I added some comments to de-confuse me.  Hence this patch.
>
> There is also a 1-line very tiny change in the code itself, where I had
> checked for "0" instead of checking for smaller than eps in one line.
> This changes a few low order bits in a doctest.

New description:

 I was reading the Continuous Hidden Markov Model code and trying to
 understand how probabilities are defined in a certain context, and got
 confused.   So I added some comments to de-confuse me.  Hence this patch.

 There is small change in the code itself, where I had checked for "0"
 instead of checking for smaller than min_sd in one line.   This makes the
 code (1) work much better with actual real world examples, and (2) is
 consistent with the old ghmm C library from sage-3.x that this code was
 supposed to replace.

 See all #12146 for feature enhancements.

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12144#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to