#12150: upgrade defect() of a finite word
---------------------------------+------------------------------------------
Reporter: sstarosta | Owner: sstarosta
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-4.8
Component: combinatorics | Keywords: finite word, defect,
palindrome, pseudopalindrome
Work_issues: | Upstream: N/A
Reviewer: Vincent Delecroix | Author: Stepan Starosta
Merged: | Dependencies:
---------------------------------+------------------------------------------
Changes (by slabbe):
* reviewer: vdelecroix => Vincent Delecroix
Comment:
> By merging both patches, Stepan becomes author of what Vincent did.
Usually, we keep both patches separated. Anyway, which patche(s) should be
reviewed? the last one only? Right now, the patchbot tries to apply all of
them which fails...
>
> Sébastien
Also, it is bad to merge patches that have already been reviewed because
one needs to start over to do the next review. Also, it is impossible to
see what Stepan did after Vincent suggestions and patch. Stepan, could you
please post a another patch which would replace the third and that would
apply on the first two and that would contain only modification made
without merge?
Thanks,
Sébastien
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12150#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
