#10621: Make Conic class able to find points over number fields
-----------------------------+----------------------------------------------
Reporter: mstreng | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.8
Component: number fields | Keywords: rational point points conic
quadratic form number field
Work_issues: | Upstream: N/A
Reviewer: John Cremona | Author: Marco Streng
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by cremona):
* status: needs_review => needs_work
* reviewer: => John Cremona
Comment:
Sorry I didn't make the September deadline...
Looks basically good, but I get some doctest failures after applying
(successfully) to 4.8.alpha4:
{{{
sage -t -long devel/sage-
main/sage/schemes/plane_conics/con_rational_field.py # 1 doctests failed
sage -t -long devel/sage-
main/sage/schemes/plane_conics/con_field.py # 2 doctests failed
sage -t -long devel/sage-
main/sage/schemes/plane_conics/con_number_field.py # 6 doctests failed
}}}
Mostly they are this:
{{{
File "/home/jec/sage-4.8.alpha4/local/lib/python/site-
packages/sage/schemes/plane_conics/con_number_field.py", line 249, in
has_rational_point
pt = self.point(T*vector([KtoB(isnorm[1][0]),
NameError: global name 'vector' is not defined
}}}
and also there is this:
{{{
File "/home/jec/sage-4.8.alpha4/devel/sage-
main/sage/schemes/plane_conics/con_number_field.py", line 290:
sage: f = (2*O).factor(); f
Expected:
(Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (-a^2 + 2*a -
3))
Got:
(Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (a^2 - 2*a + 3))
}}}
which is of course trivial, and probably due to a Pari change in the
interim.
Fix these and I'll give it a positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10621#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
