#8162: p-adic ring constructor documentation incorrect
------------------------+---------------------------------------------------
   Reporter:  dmharvey  |          Owner:  roed      
       Type:  defect    |         Status:  needs_work
   Priority:  minor     |      Milestone:  sage-4.8  
  Component:  padics    |       Keywords:            
Work_issues:            |       Upstream:  N/A       
   Reviewer:            |         Author:  David Roe 
     Merged:            |   Dependencies:            
------------------------+---------------------------------------------------
Changes (by saraedum):

  * status:  needs_review => needs_work


Comment:

 I guess one should apply 8162.2.patch.

 Even though I read the comment above I don't understand under which
 circumstances one would get a list of the form [(p,n)]. If you factor some
 q you get a factorization object. If you select one of its coefficients
 you get a tuple. The only way I could think of is casting a factorization
 to a list but would this really be useful?

 I also find the use of 'check' confusing. One would expect 'check' to
 actually check whether q is a prime power (which probably the
 ExtensionFactory does, I haven't checked). Here it is also used to disable
 some of the input formats:

 {{{
 sage: k.<alpha> = Qq((2,1)) #works
 sage: k.<alpha> = Qq((2,1),check=False)
 TypeError: 'sage.rings.integer.Integer' object does not support indexing
 }}}

 So, something that works with check does not work without check anymore.

 I can go ahead and fix these issues if you don't mind.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8162#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to