#12156: Pretty print LatexExpr directly
------------------------------------------------------------------------+---
   Reporter:  jdemeyer                                                  |       
   Owner:  jason                                
       Type:  defect                                                    |       
  Status:  needs_review                         
   Priority:  major                                                     |      
Milestone:  sage-4.8                             
  Component:  misc                                                      |       
Keywords:  sd35                                 
Work_issues:                                                            |       
Upstream:  N/A                                  
   Reviewer:  Andrey Novoseltsev, Punarbasu Purkayastha, John Palmieri  |       
  Author:  Jeroen Demeyer, Punarbasu Purkayastha
     Merged:                                                            |   
Dependencies:  #12197                               
------------------------------------------------------------------------+---
Changes (by jhpalmieri):

  * reviewer:  Andrey Novoseltsev, Punarbasu Purkayastha => Andrey
               Novoseltsev, Punarbasu Purkayastha, John
               Palmieri


Old description:

> An object of type `LatexExpr` should be pretty-printed as-is, that is
> {{{
> sage: pretty_print(LatexExpr('x^2 + 1'))
> }}}
> should really typeset {{{"x^2 + 1"}}} instead of displaying the string
> {{{"x^2 + 1"}}}.
>
> Also, import `LatexExpr` globally.
>
> '''Apply''' [attachment:12156_latex_pretty_print.patch],
> [attachment:12156_reviewer.patch],
> [attachment:12156_add_LatexExpr.patch],
> [attachment:12156_extra_doc.patch],
> [attachment:12156_fix_latex.patch]

New description:

 An object of type `LatexExpr` should be pretty-printed as-is, that is
 {{{
 sage: pretty_print(LatexExpr('x^2 + 1'))
 }}}
 should really typeset {{{"x^2 + 1"}}} instead of displaying the string
 {{{"x^2 + 1"}}}.

 Also, import `LatexExpr` globally.

 '''Apply''' [attachment:12156_latex_pretty_print.patch],
 [attachment:12156_reviewer.patch], [attachment:12156_add_LatexExpr.patch],
 [attachment:12156_extra_doc.patch],
 [attachment:12156_fix_latex.patch], [attachment:12156_jhp.patch]

--

Comment:

 I think I'll join the patch party: I'm attaching a patch which rewords a
 few docstrings. Otherwise, everything looks good to me.  With the patch at
 #12197 and all of the patches here, all tests pass.

 I'm willing to give everything but my patch a positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12156#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to