#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
   Reporter:  SimonKing                                      |          Owner:  
tbd                  
       Type:  defect                                         |         Status:  
needs_review         
   Priority:  critical                                       |      Milestone:  
sage-5.0             
  Component:  performance                                    |       Keywords:  
categories regression
Work_issues:  Update reviewer patch                          |       Upstream:  
N/A                  
   Reviewer:  Jeroen Demeyer, Nicolas M. ThiƩry, Simon King  |         Author:  
Simon King           
     Merged:                                                 |   Dependencies:  
#9138 #11911 #9562   
-------------------------------------------------------------+--------------
Changes (by SimonKing):

  * status:  needs_work => needs_review


Comment:

 The following timings are on a different machine than the timings above,
 but I think they show that the new hash method is pretty good:
 {{{
 sage: timeit("Rings()",number=10000)
 10000 loops, best of 3: 981 ns per loop
 sage: R = Rings()
 sage: timeit("hash(R)",number=10000)
 10000 loops, best of 3: 107 ns per loop
 }}}

 The tests at least in sage/categories pass, so, I put it back to "needs
 review"

 Apply trac11900_category_speedup_combined.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:214>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to