#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
Reporter: SimonKing | Owner:
tbd
Type: defect | Status:
positive_review
Priority: critical | Milestone:
sage-5.0
Component: performance | Keywords:
categories regression
Work_issues: | Upstream:
N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry, Simon King | Author:
Simon King
Merged: | Dependencies:
#11319, #9138, #11911, #9562
-------------------------------------------------------------+--------------
Changes (by nthiery):
* status: needs_review => positive_review
Comment:
Replying to [comment:219 SimonKing]:
> AFAIU, the current version of the patch is in sage-5.0.prealpha0. I hope
this will make it more easy to finish reviewing the patch!
I have been through the patch, and it looks good to me. Thanks so much
Simon for your hard work on this! It goes far beyond the extra mile.
I am running the tests on my machine. I'll set a positive review when it's
done. In case I forget to: if in three hours you have not heard from me,
you can set a positive review on my behalf.
Just one note: I hope nobody had a pile of patches on top of the
matrix/vector space code, since the many little doc improvements there
(like EXAMPLES: -> EXAMPLES::) will force quite some rebasing. Please make
this in a separate ticket next time, or just leave it to whoever is
working on those files.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:220>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
