#12187: Bug in is_singular for plane projective curves
----------------------------------+-----------------------------------------
Reporter: johanbosman | Owner: AlexGhitza
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: algebraic geometry | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Loeffler | Author: Charlie Turner
Merged: | Dependencies:
----------------------------------+-----------------------------------------
Changes (by davidloeffler):
* status: needs_review => positive_review
* reviewer: => David Loeffler
Comment:
Hi Charlie,
This looks good but there are a couple of niggling issues with formatting
of the docstring: there is a rule that no tab characters should appear in
Sage source files, and code blocks in docstrings need to have a double
colon and a blank line before them.
I've uploaded a new, corrected patch. Since I've only changed whitespace,
I don't think we need another round of checking. All tests pass on
selmer.warwick, so this gets a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12187#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
