#11599: Wrap fan morphism in toric morphism
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.8
Component: algebraic geometry | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Andrey Novoseltsev | Author: Volker Braun
Merged: | Dependencies:
----------------------------------+-----------------------------------------
Comment(by davideklund):
Replying to [comment:21 novoselt]:
> Replying to [comment:19 davideklund]:
> > Looking good.
> >
> > There is a typo in trac_11599_homset_new_coercion_model.patch line
482: "...the heigh of the coordinates", should be "height".
>
> "Looking good" as in positive review to the second patch with the fixed
typo?-)
Sorry, I meant that it looks good in general, would need to go through it
more carefully for a review. I was planning to look at this ticket though,
I hope to contribute to the review of it (but it might take a while for me
to get started since I will be traveling).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11599#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.