#12248: Do not run "make -q" when upgrading
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: new
Priority: blocker | Milestone: sage-4.8
Component: build | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Changes (by newvalueoldvalue):
* author: => Jeroen Demeyer
Old description:
> The script `spkg/install` contains the lines
> {{{
> # Skip the rest if nothing to do (i.e., to [re]build):
> # If "make" doesn't understand the -q option (although we require
> # GNU make, which supports it), it should exit with a non-zero status
> # which is not a problem.
> if ${MAKE:-make} -q -f standard/deps $1; then
> echo "Nothing to (re)build / all up-to-date."
> exit 0
> fi
> }}}
>
> This runs `make` with the `-q` option, which (via the makefile
> `spkg/standard/deps`) in turn runs `sage-spkg`. When upgrading, the file
> `sage-spkg` is not automatically upgraded, so we can have an old `sage-
> spkg` which does not understand the `-q` option which causes build
> failures.
New description:
The script `spkg/install` contains the lines
{{{
# Skip the rest if nothing to do (i.e., to [re]build):
# If "make" doesn't understand the -q option (although we require
# GNU make, which supports it), it should exit with a non-zero status
# which is not a problem.
if ${MAKE:-make} -q -f standard/deps $1; then
echo "Nothing to (re)build / all up-to-date."
exit 0
fi
}}}
This runs `make` with the `-q` option, which (via the makefile
`spkg/standard/deps`) in turn runs `sage-spkg`. When upgrading, the file
`sage-spkg` is not automatically upgraded, so we can have an old `sage-
spkg` which does not understand the `-q` option which causes build
failures. This is a problem introduced by #12016.
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12248#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
