#12248: Do not run "make -q" when upgrading
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.8
Component: build | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Old description:
> The script `spkg/install` contains the lines
> {{{
> # Skip the rest if nothing to do (i.e., to [re]build):
> # If "make" doesn't understand the -q option (although we require
> # GNU make, which supports it), it should exit with a non-zero status
> # which is not a problem.
> if ${MAKE:-make} -q -f standard/deps $1; then
> echo "Nothing to (re)build / all up-to-date."
> exit 0
> fi
> }}}
>
> This runs `make` with the `-q` option, which (via the makefile
> `spkg/standard/deps`) in turn runs `sage-spkg`. This changed recently,
> before #12016 `make -q` didn't run `sage-spkg`.
>
> When upgrading, the file `sage-spkg` is not automatically upgraded, so we
> can have an old `sage-spkg` which does not understand the `-q` option
> which causes build failures. This is a problem introduced by #12016.
New description:
The script `spkg/install` contains the lines
{{{
# Skip the rest if nothing to do (i.e., to [re]build):
# If "make" doesn't understand the -q option (although we require
# GNU make, which supports it), it should exit with a non-zero status
# which is not a problem.
if ${MAKE:-make} -q -f standard/deps $1; then
echo "Nothing to (re)build / all up-to-date."
exit 0
fi
}}}
This runs `make` with the `-q` option, which (via the makefile
`spkg/standard/deps`) in turn runs `sage-spkg`. This changed recently,
before #12016 `make -q` didn't run `sage-spkg`.
When upgrading, the file `sage-spkg` is not automatically upgraded, so we
can have an old `sage-spkg` which does not understand the `-q` option
which causes build errors (only visible in the log files), for example in
`spkg/logs/patch-2.5.9.p2.log`.
This is a problem introduced by #12016.
--
Comment(by jdemeyer):
Replying to [comment:6 jhpalmieri]:
> Why did #12016 cause this? Is it because of all of the plus signs in
spkg/standard/deps?
Yes. Those plus signs mark a make rule as recursive.
Replying to [comment:7 jhpalmieri]:
> Unless I made a mistake, I was able to upgrade from 4.4 and 4.5.3 to
Sage 4.8.alpha6 plus #9958 and its prerequisites (since that's what I was
looking at earlier). I was also able to upgrade after applying the patch
here.
Perhaps I should have been more clear. The upgrade might work without
this patch, but you will see a failed build attempt for example in
`spkg/logs/patch-2.5.9.p2.log`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12248#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
