#12171: Update MPFI to 1.5.0
---------------------------+------------------------------------------------
   Reporter:  mhansen      |          Owner:  tbd                         
       Type:  enhancement  |         Status:  needs_review                
   Priority:  major        |      Milestone:  sage-4.8                    
  Component:  packages     |       Keywords:  sd35                        
Work_issues:               |       Upstream:  N/A                         
   Reviewer:               |         Author:  Mike Hansen, Paul Zimmermann
     Merged:               |   Dependencies:                              
---------------------------+------------------------------------------------

Comment(by fbissey):

 I further inspected the spkg. There is one issue
 {{{
  hg status
 ! patches/configure.ac
 ! patches/configure.ac.patch
 }}}
 You have to tell hg to remove them, just removing them with "rm" is not
 enough.
 {{{
  hg addremove
 }}}
 will do the trick then you can commit and make the spkg.
 As mentioned above I would also like you to add a section to spkg-install
 that runs "make check" if SAGE_CHECK is set to yes.
 Once all that is done I'll have another look but it should be a positive
 review then.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12171#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to