#10057: Change import location for decorator_defaults in sagenb interact.py
-------------------------------+--------------------------------------------
Reporter: jason | Owner: jason, was
Type: defect | Status: needs_info
Priority: major | Milestone:
Component: notebook | Keywords: sd35.5
Work_issues: | Upstream: N/A
Reviewer: Paul Zimmermann | Author: Mike Hansen
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Comment(by jsrn):
Replying to [comment:3 zimmerma]:
> Mike,
>
> I started to review that ticket, but I'm puzzled since
> {{{
> sage: from sage.misc.misc import decorator_defaults
> }}}
> still works. Shouldn't it fail?
>
The reason it doesn't fail is because sage.misc.misc contains an import
statement, importing decorator_defaults among other (line 2735). This was
introduced in #9907 for backwards compatibility, in case users assumed
that these decorators would still be in sage.misc.misc. I assumed this
would be a temporary thing, just as for keyword and attribute changes.
#9907 was merged 14 months ago, so this is longer than the deprecation
lifetime, but on the other hand, no deprecation warning has been issued to
users doing the wrong thing for these past 14 months. I'm not sure what is
usually done under such circumstances. Also, removing the import statement
from sage.misc.misc will result in the pickle jar breaking, and I'm not
sure how to remedy that and what consequences it might have. Need expert
opinion here.
> Also, shouldn't the patch include a doctest?
Maybe that's just me, but isn't it a bit too much including a doctest just
for a relocation of a function? It's still the same function.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10057#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
