#12288: hg_sage and friends should unset HGPLAIN
-----------------------------------+----------------------------------------
Reporter: jhpalmieri | Owner: jason
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-4.8
Component: misc | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: John Palmieri
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Old description:
> This is a followup to #12058. When you run `hg_sage.log()` in Sage, it
> runs the command `hg` which has been installed in `SAGE_LOCAL/bin`. It
> does not run `sage --hg`. Therefore, because of the changes in #12058,
> the variable `HGPLAIN` is set to "yes", so the pager is turned off. We
> should instead either run `sage --hg` or unset `HGPLAIN` when running
> commands using `hg_sage`.
>
> ------
>
> Suggestion: apply [attachment:trac_12288-sage-hg.patch] (rather than
> [attachment:trac_12288-unset-HGPLAIN.patch]).
>
> ----
>
> Apply [attachment:trac_12288-sage-hg.patch] and
> [attachment:trac_12288-reviewer.patch].
New description:
This is a followup to #12058. When you run `hg_sage.log()` in Sage, it
runs the command `hg` which has been installed in `SAGE_LOCAL/bin`. It
does not run `sage --hg`. Therefore, because of the changes in #12058,
the variable `HGPLAIN` is set to "yes", so the pager is turned off. We
should instead either run `sage --hg` or unset `HGPLAIN` when running
commands using `hg_sage`.
------
Suggestion: apply [attachment:trac_12288-sage-hg.patch] (rather than
[attachment:trac_12288-unset-HGPLAIN.patch]).
----
Apply [attachment:trac_12288-sage-hg.v2.patch].
--
Comment(by kcrisman):
Ok, seems fine to me, and applies/passes/looks nice/etc.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12288#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
