#11771: sage crashes on some degenerate flint xgcd's
---------------------------------------------------------+------------------
   Reporter:  lftabera                                   |          Owner:  
AlexGhitza                                               
       Type:  defect                                     |         Status:  
needs_review                                             
   Priority:  critical                                   |      Milestone:  
sage-4.8                                                 
  Component:  basic arithmetic                           |       Keywords:  
flint, crash, xgcd fmpq_poly rational polynomials, sd35.5
Work_issues:                                             |       Upstream:  N/A 
                                                     
   Reviewer:  Luis Felipe Tabera Alonso, Leif Leonhardy  |         Author:  
Sebastian Pancratz, Luis Felipe Tabera Alonso            
     Merged:                                             |   Dependencies:      
                                                     
---------------------------------------------------------+------------------
Changes (by zimmerma):

  * keywords:  flint, crash, xgcd fmpq_poly rational polynomials => flint,
               crash, xgcd fmpq_poly rational polynomials,
               sd35.5


Comment:

 just some quick comments to keep this ticket alive:

 * in line 171 of the patched {{{fmpq_poly.c}}} I don't understand why the
 size of the denominator is used since {{{temp}}} only depends on the
 numerator

 * further below {{{tempgcd}}} can be allocated to the size of the
 denominator only, since by definition the gcd is bounded by {{{den}}}.

 * and {{{tempgcd}}} can be used instead of {{{temp}}} to divide {{{den}}}
 by {{{tempgcd}}}, or better {{{fmpz_tdiv(f->den, f->den, tempgcd)}}}?

 Paul

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11771#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to