#11028: More Modular ComplexPlot
-----------------------------------+----------------------------------------
Reporter: evanandel | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.8
Component: graphics | Keywords: complex plot riemann map
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Ethan Van Andel
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Old description:
> I modified !ComplexPlot to be more flexible and modular. The __init__
> method now takes rgb_data instead of z_values as input. This permits
> users to decide how they want to represent their complex data.
> Adjustments have been made to both !RiemannMap.plot_colored and
> complex_plot.
>
> I also removed the now-redundant !ColorPlot from riemann.pyx.
>
> ----
> Apply only [attachment:trac-11028-modular-complex-plot.2.2.patch].
New description:
I modified !ComplexPlot to be more flexible and modular. The __init__
method now takes rgb_data instead of z_values as input. This permits users
to decide how they want to represent their complex data. Adjustments have
been made to both !RiemannMap.plot_colored and complex_plot.
I also removed the now-redundant !ColorPlot from riemann.pyx.
----
Apply only [attachment:trac-11028-modular-complex-plot.2.3.patch].
--
Comment(by evanandel):
It turns out those test failures were because riemann's complex_to_rgb is
cdefed and therefore not importable for outside modules. I fixed that
changing it to a cpdef.
I'm not sure if I just didn't catch those failures before, or if something
changed to make it a problem. Regardless, it should work now.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11028#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
