#11975: Chow-Heegner points
-------------------------------------+--------------------------------------
   Reporter:  was                    |          Owner:  cremona      
       Type:  enhancement            |         Status:  needs_info   
   Priority:  major                  |      Milestone:  sage-5.0     
  Component:  elliptic curves        |       Keywords:               
Work_issues:  Gamma0(N) equivalence  |       Upstream:  N/A          
   Reviewer:  John Cremona           |         Author:  William Stein
     Merged:                         |   Dependencies:               
-------------------------------------+--------------------------------------
Changes (by cremona):

  * status:  needs_review => needs_info


Comment:

 The fix looks good to me.  I am testing now (done & fine).  I am slightly
 worried that the equality tests for i and rho using == would be better
 done using equality up to some precision?

 One could cache the "constants" i, rho and their stabilisers, but it is
 hardly worth while since it will only be rare that these last lines of
 code are used in practice.

 Lastly, do you need to test for both rho and rhobar given that you have
 normalised the fund.dom.reps.?  If so, the third of your special cases
 will not happen.
 {{{
 sage: z = (2*CC(pi)*CC(I)/6).exp()
 sage: z
 0.500000000000000 + 0.866025403784439*I
 sage: canonicalize_sl2z(z)
 (-0.500000000000000 + 0.866025403784439*I, None)
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11975#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to