#11975: Chow-Heegner points
-------------------------------------+--------------------------------------
Reporter: was | Owner: cremona
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-5.0
Component: elliptic curves | Keywords:
Work_issues: Gamma0(N) equivalence | Upstream: N/A
Reviewer: John Cremona | Author: William Stein
Merged: | Dependencies:
-------------------------------------+--------------------------------------
Comment(by was):
Replying to [comment:15 cremona]:
> The fix looks good to me. I am testing now (done & fine). I am
slightly worried that the equality tests for i and rho using == would be
better done using equality up to some precision?
It is, in a sense, because it happens in {{{C=ComplexField(prec)}}}, where
prec is the parameter that gets passed in.
> One could cache the "constants" i, rho and their stabilisers, but it is
hardly worth while since it will only
> be rare that these last lines of code are used in practice.
Since the precision changes a lot, this might not be worth it, given how
much other work happens and how rare this case is.
> Lastly, do you need to test for both rho and rhobar given that you have
normalised the fund.dom.reps.?
Nope -- very good point. I've removed that.
Is there anything else you want me to change?
- William
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11975#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
