#12327: Improve loading page of Mac App
-----------------------------------+----------------------------------------
   Reporter:  iandrus              |          Owner:  iandrus     
       Type:  enhancement          |         Status:  needs_review
   Priority:  major                |      Milestone:  sage-5.0    
  Component:  interfaces           |       Keywords:  mac app,mac 
Work_issues:                       |       Upstream:  N/A         
   Reviewer:  Karl-Dieter Crisman  |         Author:  Ivan Andrus 
     Merged:                       |   Dependencies:  #11080      
-----------------------------------+----------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Karl-Dieter Crisman
  * dependencies:  => #11080
  * author:  => Ivan Andrus


Comment:

 More or less all looks ok.  In line 127 we have
 {{{
 <p> If the server is already runn
 }}}
 but I think HTML will ignore the extra whitespace.  I assume the CSS is
 all pretty nice; is there a reason not to use default sizes for things
 like h1, h2, h3?

 It's taking too long for the dmg to build, so I'll have to finish the
 review tomorrow morning.  Also modulo whether port 8080 actually is the
 new flask port, but #12310 and other references would seem to cover this
 if I make the new notebook a dependency.  That makes this and #11080
 dependencies of each other, but I think that's appropriate.

 Unless... what about [comment:84:ticket:11080]?  That's not addressed
 here, is it addressed elsewhere?  Otherwise you might want to make this
 still port 8000 so it can get merged and address that where you take care
 of the other issue.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12327#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to