#12327: Improve loading page of Mac App
-----------------------------------+----------------------------------------
Reporter: iandrus | Owner: iandrus
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: interfaces | Keywords: mac app,mac
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Ivan Andrus
Merged: | Dependencies: #11080
-----------------------------------+----------------------------------------
Comment(by iandrus):
Replying to [comment:4 kcrisman]:
> More or less all looks ok. In line 127 we have
> {{{
> <p> If the server is already runn
> }}}
> but I think HTML will ignore the extra whitespace. I assume the CSS is
all pretty nice; is there a reason not to use default sizes for things
like h1, h2, h3?
Yes it should ignore the whitespace. As to sizes of h1, etc. I just
modified some css from sagemath.org so that I would get the colors right
and they had changed the sizes.
> It's taking too long for the dmg to build, so I'll have to finish the
review tomorrow morning. Also modulo whether port 8080 actually is the
new flask port, but #12310 and other references would seem to cover this
if I make the new notebook a dependency. That makes this and #11080
dependencies of each other, but I think that's appropriate.
I think that's probably right.
> Unless... what about [comment:84:ticket:11080]? That's not addressed
here, is it addressed elsewhere? Otherwise you might want to make this
still port 8000 so it can get merged and address that where you take care
of the other issue.
That's not addressed here, nor elsewhere. When I finally got 5.0.beta1 to
build and tested it, it wasn't a problem. I'm going to comment on it over
there as well now that you reminded me.
Now that I think about it people might run older versions of Sage and then
it would be port 8000 anyway. It would be easy to put 2 links. I'm not
sure it's worth it though since they should never have to click the link,
and the server be running on a different port anyway since 8000 or 8080
might have been taken by something else (e.g. `hg serve`). It's trivial
to add it, but I don't want to do it if it means you will have to build
the dmg again to review it. FWIW you can set `SAGE_APP_DMG` to no to
avoid building the dmg, though it still takes forever to build the
application itself.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12327#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
