#12292: charpoly is recomputed when called with a different variable
-----------------------------------------+----------------------------------
Reporter: zimmerma | Owner: jason, was
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.0
Component: linear algebra | Keywords: sd35.5
Work_issues: rebase for 4.8, fix typos | Upstream: N/A
Reviewer: Paul Zimmermann | Author: Michael Orlitzky
Merged: | Dependencies:
-----------------------------------------+----------------------------------
Changes (by zimmerma):
* status: needs_review => needs_work
* reviewer: => Paul Zimmermann
* work_issues: => rebase for 4.8, fix typos
Comment:
Michael,
the patch fails to apply to Sage 4.8, for which version did you make it?
{{{
----------------------------------------------------------------------
| Sage Version 4.8, Release Date: 2012-01-20 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
Loading Sage library. Current Mercurial branch is: 12292
sage: hg_sage.import_patch("/tmp/sag
/tmp/sage-4.8 /tmp/sage-trac_12292.patch
/tmp/sage-4.8.alpha6
sage: hg_sage.import_patch("/tmp/sage-trac_12292.patch")
cd "/usr/local/sage-4.8/sage/devel/sage" && sage --hg import "/tmp/sage-
trac_12292.patch"
applying /tmp/sage-trac_12292.patch
patching file sage/matrix/matrix2.pyx
Hunk #4 FAILED at 1422
Hunk #5 FAILED at 1438
Hunk #6 FAILED at 1467
3 out of 6 hunks FAILED -- saving rejects to file
sage/matrix/matrix2.pyx.rej
abort: patch failed to apply
}}}
Also there is a tiny typo in the patch: {{{indepenedent}}} should be
{{{independent}}} (five times). Also I'm not sure about the comment:
{{{
Prior to trac #12292, the call to
A.det() would attempt to use the cached charpoly, and crash [...]
}}}
Shouldn't it be #6442 instead?
Paul
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12292#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
