#12318: **kwds in the Graph constructor is confusing
----------------------------+-----------------------------------------------
Reporter: brunellus | Owner: jason, ncohen, rlm
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-5.0
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
----------------------------+-----------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Wow, veeeeeeery good idea !!!
Several remarks :
* in BipartiteGraph : could you explicit in the description of the
``check`` flag what "changing the graph to be bipartite" means ? The
documentation later says "However, if one specifies check=False, the
offending edges are simply deleted (along with those vertices not
appearing in either list)" but it is easy to miss.
* Your test
{{{
if len(partition[0]) > 0 or len(partition[1]) > 0:
}}}
Can be replaced by
{{{
if partition[0] or partition[1]:
}}}
Python is funny sometimes `:-p`
* Why did you replace
{{{
#. An arbitrary graph (finds a bipartition).
#. A graph and a bipartition.
}}}
By
{{{
#. An arbitrary graph.
}}}
? `O_o`
* The line "- all remaining arguments are passed to the ``Graph``
constructor" would fit well inside of a ".. NOTE::" field.
* What about making what "``convert_empty_dict_labels_to_None``" does
more explicit ? Something saying "you don't have to care as long as you do
not deal with NetworkX". For instance : "This arguments sets the default
edge labels used by NetworkX (empty dictionaries) to be replaced by
``None``, the default Sage edge label. It is set to ``True`` by default.
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12318#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
