#12347: make install broken in Sage 4.8
------------------------+---------------------------------------------------
   Reporter:  zimmerma  |          Owner:  GeorgSWeber
       Type:  defect    |         Status:  needs_work 
   Priority:  major     |      Milestone:  sage-5.0   
  Component:  build     |       Keywords:             
Work_issues:            |       Upstream:  N/A        
   Reviewer:            |         Author:             
     Merged:            |   Dependencies:             
------------------------+---------------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:9 ppurka]:
 > @jhpalmieri: I added -u to make sure that the second time `make install`
 is run, cp does not go around copying the files all over again.

 Solaris is a supported platform for Sage on which the `-u` option is not
 recognized, so it doesn't matter too much why you added it: it's not going
 to work.

 > The options `-r`, `-v` were all present from before.

 But while you're fixing other things, you might as well fix this.  Just
 use `-R` or `-pR` instead.

 > `ln -f` was needed in case the user ran `make install` yet again,
 otherwise ln would give error. If the first invocation of make install
 doesn't fail, then there is no need to use -f with ln.

 Same comment as before: it's not going to work this way, so you should do
 it a different way.  (For example, first run 'rm -f ...' on the link, then
 do 'ln -s ...'.)

 > If `cp` is unreliable then what is the alternative (it is actually quite
 reliable on linux with the `-a` option, that is, it copies symlinks
 properly)? Alternatively, can we assume that `rsync` is available on all
 platforms and use rsync instead?

 I think that 'cp -pR' is reliable on all platforms.  Note also that the
 'make install' option says "Experimental use only!", so I don't think it's
 been well-maintained or supported, or even used much, which is why, for
 example, the `-v` option for cp wasn't removed earlier.  But if you're
 working on this, you should do it right, so that it works on all supported
 platforms.  Using POSIX-standard commands should be completely reliable;
 every platform's version of 'cp' should support the POSIX-standard options
 for cp.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12347#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to