#12414: system-wide default color
---------------------------+------------------------------------------------
   Reporter:  jason        |          Owner:  jason, was 
       Type:  enhancement  |         Status:  needs_work 
   Priority:  major        |      Milestone:  sage-5.0   
  Component:  graphics     |       Keywords:             
Work_issues:               |       Upstream:  N/A        
   Reviewer:               |         Author:  Jason Grout
     Merged:               |   Dependencies:             
---------------------------+------------------------------------------------
Changes (by kcrisman):

  * status:  needs_review => needs_work


Comment:

 I see.  In that case, you forgot to change the documentation!
 {{{

        Parses the color.

        It transforms a valid color string into a color object and a color
        object into an RBG tuple of length 3. Otherwise, it multiplies the
        info by the base color.

 }}}

 ----
 On the other issue - before:
 {{{
 sage: [t.color for t in G.texture_set()]
 [RGB color (1.0, 0.0, 0.0), RGB color (1.0, 0.0, 0.0), RGB color (1.0,
 1.0, 0.0)]
 }}}
 after:
 {{{
 sage: [t.color for t in G.texture_set()]
 [(1.0, 0.0, 0.0), (1.0, 0.0, 0.0), (1.0, 1.0, 0.0)]
 }}}
 This really won't break anything in the initialization of `Texture` where
 this is used?

 ----
 Also, I just found a doctest typo, unnoticed because of the fact that
 `Texture` pretty much takes any input without complaining.  You didn't do
 this, but we should fix it here.
 {{{

         sage: Texture(ambiant=0.7)
         Texture(texture..., 6666ff)
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12414#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to