#12414: system-wide default color
-----------------------------------+----------------------------------------
Reporter: jason | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: graphics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Jason Grout
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* reviewer: => Karl-Dieter Crisman
Comment:
> I'm waffling about whether I should back out the texture changes (I
don't have time now to dive deeply into the 3d plotting). What do you
think? I can just put an extra test in there that returns the default
color if no color is passed in.
I think that is the easier solution for now. I assume that most people
wouldn't care, but I think there was some method to the way it's returned,
so that the same parsing function could be used in a few different
contexts. I don't know whether `parse_color` is used outside of the
initialization of `Texture`, but I think it would be unfortunate for
attributes of `Texture`s to change format without discussion somewhere by
someone who uses them.
If you do change that back, please give the new patch a different name,
because then we have this other fix still on Trac for easy reference
later.
> I've attached a patch which takes care of the typo and docs.
Except there was a typo there from before this ticket which I just
noticed. Aargh!
{{{
It transforms a valid color description into an RBG tuple of
}}}
What is RBG, kcrisman? Silly... This would be needed no matter how you
deal with `parse_color`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12414#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
