#12015: L-series attached to general Euler products
-----------------------------+----------------------------------------------
   Reporter:  was            |          Owner:  was     
       Type:  enhancement    |         Status:  new     
   Priority:  major          |      Milestone:  sage-5.0
  Component:  number theory  |       Keywords:  sd35.5  
Work_issues:                 |       Upstream:  N/A     
   Reviewer:                 |         Author:          
     Merged:                 |   Dependencies:          
-----------------------------+----------------------------------------------

Comment(by was):

 The patch trac_12015-part1_updated.patch has some issues:

   1. It patches a file called
 {{{sage/lfunctions/eulerprod_with_tripleprod.py}}} that is not even in my
 patch.   I'm guessing you took some old file from Sage days I had provided
 and started working on it.  However, that has little to do with the code
 in the patch I posted to this ticket.

   2. Why was this change made?
 {{{
         118             sage: K.<a> = NumberField(x^2-x-1)
         119             sage: K.<a> = NumberField(x^2+1)
 }}}

   3. The code needs to be indented here, but isn't (in your patch):
 {{{
         174             EXAMPLES::
         175
         176             sage: from sage.lfunctions.eulerprod import
 LSeries
         177             sage: from sage.lfunctions.eulerprod import
 LSeriesDerivative
         178             sage: K.<a>=NumberField(x^2+1)
         179             sage: L=LSeries(K); L
 }}}

    4. Here in your patch the code is indented (good), but there is only
 one colon (instead of two) after EXAMPLES:
 {{{
         508             EXAMPLES:
         509
         510                 sage: from sage.lfunctions.eulerprod import
 LSeriesAbstract
         511                 sage: L1 = LSeriesAbstract(conductor=1,
 hodge_numbers=[0], weight=1, epsilon=1, poles=[1], residues=[-1],
 base_field=QQ)
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12015#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to