#12357: Make groupoids garbage collectable
-------------------------------+--------------------------------------------
   Reporter:  SimonKing        |          Owner:  rlm                      
       Type:  defect           |         Status:  needs_info               
   Priority:  major            |      Milestone:  sage-5.0                 
  Component:  memleak          |       Keywords:  groupoid cache Cernay2012
Work_issues:  tests for None?  |       Upstream:  N/A                      
   Reviewer:                   |         Author:  Simon King               
     Merged:                   |   Dependencies:  #12313                   
-------------------------------+--------------------------------------------
Changes (by jpflori):

  * keywords:  => groupoid cache Cernay2012
  * status:  needs_review => needs_info
  * work_issues:  => tests for None?


Comment:

 This is the simplest patch of the cache problems suite, and it does not
 depend on !#715, so I begin with this one.

 I'm a little bit confused by all those tests for None in your patch.

 Isn't the first one sufficient?

 More specifically, the second test "if S is not None" isn't superfluous ?

 And if it is not None, can G be None ? (I guess there is some cython
 voodoo involved here)

 To answer my own question, I guess it is none if S is not a Parent (as in
 your example with 1).

 Once you answer me back, I'll post a reviewer patch with some additional
 minor corrections.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12357#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to