#12357: Make groupoids garbage collectable
-------------------------------+--------------------------------------------
Reporter: SimonKing | Owner: rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: memleak | Keywords: groupoid cache Cernay2012
Work_issues: tests for None? | Upstream: N/A
Reviewer: | Author: Simon King
Merged: | Dependencies: #12313
-------------------------------+--------------------------------------------
Changes (by SimonKing):
* status: needs_info => needs_review
Comment:
Yes, the test "if S is not None" in line 103 seems redundant, as S being
None would result in an error being raised in line 92.
Concerning Cython voodoo: If S is not None and not of type Parent, then `G
== S` in line 106 would result in a type error (since G is cdefined) -
which is desired behaviour. But if S were None, then `G == S` in line 106
would not complain, and then line 109 would segfault. This is why there
must be a test for the corner case - of course, one test would be enough.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12357#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
