#12356: many missing class number 2 orders in CM j-invariant function over
quadratic fields
-------------------------------------------+--------------------------------
Reporter: cremona | Owner: cremona
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.0
Component: elliptic curves | Keywords:
Work_issues: | Upstream: N/A
Reviewer: John Cremona, William Stein | Author: John Cremona,
William Stein
Merged: | Dependencies:
-------------------------------------------+--------------------------------
Comment(by cremona):
After all these years I still manage to lose large chunks of texts right
after typing them. In this case I had been typing into this box, then
clicked to upload a patch, after which the text had gone. So here's what
the reviewer patch does:
1. trivial fixes to docstrings to keep Sphinx happy and tidy up
2. small change to code. There is a factor in the formula which is
usually 1 but can be 2 or 3 and the factor is in the denominator so cannot
be ignored without risking losing solutions. I have inserted it, though I
did not come up with any case in which this would actually cause an error.
I also have several suggestions for making the new code more efficient,
but it is fine for small h and the new code replaces *wrong* code for h=2
which did not work at all for h>2, so the efficiency question can be dealt
with on a separate ticket.
I give a positive review apart from the issue in #2 above, so if William
agrees with my change we can together give an overall positive review; or
ask a 3rd party.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12356#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
