#12356: many missing class number 2 orders in CM j-invariant function over
quadratic fields
-------------------------------------------+--------------------------------
   Reporter:  cremona                      |          Owner:  cremona           
         
       Type:  defect                       |         Status:  needs_review      
         
   Priority:  critical                     |      Milestone:  sage-5.0          
         
  Component:  elliptic curves              |       Keywords:                    
         
Work_issues:                               |       Upstream:  N/A               
         
   Reviewer:  John Cremona, William Stein  |         Author:  John Cremona, 
William Stein
     Merged:                               |   Dependencies:                    
         
-------------------------------------------+--------------------------------

Comment(by was):

 I fixed this one line in your patch (which was wrong, and simply reposted
 it with the line fixed):
 {{{
                     # we have h(D*f^2) >= (1/c)*h(D)*phi_D(f) >=
 h(D)*euler_phi(f), where
 }}}
 changed to
 {{{
                     # we have h(D*f^2) >= (1/c)*h(D)*phi_D(f) >= (1/c)*
 h(D)*euler_phi(f), where
 }}}

 With this change, I'm happy with your patch, so I think you can set it to
 positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12356#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to