#12466: test whether a polynomial is cyclotomic
-----------------------------+----------------------------------------------
Reporter: sstarosta | Owner: sstarosta
Type: task | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: number theory | Keywords: Cernay2012
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by hivert):
Hi Stepan,
I had a quick look at you patch. I have two comment:
- There is a proper syntax for reference and algorithm please see:
http://www.sagemath.org/doc/developer/conventions.html#docstring-markup-
with-rest-and-sphinx. I don't have the time to fix it myself.
- More important, I think your code should go in a file which is not
dependent on a particular implementation of polynomial. I think
sage/rings/polynomial/polynomial_element.pyx is a good place. You'll find
there methods such as ({{{squarefree_decomposition, is_square}}}). Maybe
putting a function in {{{cyclotomic.pyx}}} and a frontend method in
{{{polynomial_element}}}, that is having all cyclotomic algorithm in the
same place, is a better solution.
Thanks for this nice work !
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12466#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
