#7027: clean up f2c spkg
-----------------------------------------------------+----------------------
Reporter: drkirkby | Owner: tbd
Type: defect | Status:
needs_work
Priority: major | Milestone:
sage-5.0
Component: build | Keywords:
Work_issues: patch success test, immortal dotfiles | Upstream: N/A
Reviewer: Michael Orlitzky | Author: R.
Andrew Ohana
Merged: | Dependencies:
-----------------------------------------------------+----------------------
Changes (by mjo):
* status: needs_review => needs_work
* work_issues: => patch success test, immortal dotfiles
Comment:
Replying to [comment:11 drkirkby]:
> I would have thought it sensible to check the return value of 'patch'.
Any changes in the package are could easily stop the patch applying
cleanly, if at all, yet that is not tested.
If we want to go this route, we'll have to set the fuzz factor. Otherwise,
GNU patch, at least, will happily return success:
{{{
$ emacs makefile
$ patch -p0 < ../../patches/libf2c.makefile.patch
patching file makefile
Hunk #1 succeeded at 73 with fuzz 1 (offset 3 lines).
$ echo $?
0
}}}
Using `--fuzz=0` should catch that, but will still miss large offsets. I
don't know if there's a way to catch those... `patch` is returning success
here even for huge offsets:
{{{
$ patch --fuzz=0 -p0 < ../../patches/libf2c.makefile.patch
patching file makefile
Hunk #1 succeeded at 111 (offset 41 lines).
$ echo $?
0
}}}
Whoever is upgrading the package would hopefully check for this, but maybe
there's a smarter way that I haven't found yet.
Anyway, these are back =)
{{{
$ sage -hg status
? ._.hg
? ._.hgignore
? ._SPKG.txt
? ._spkg-install
? patches/._f2c.makefile
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7027#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
