#12454: A draw_rauzy_fractal method for WordMorphism
-----------------------------+----------------------------------------------
Reporter: tjolivet | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: combinatorics | Keywords: rauzy fractal, substitution,
word morphism
Work_issues: | Upstream: N/A
Reviewer: vdelecroix | Author: tjolivet
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by vdelecroix):
* reviewer: => vdelecroix
Comment:
Hello,
Nice, all tests pass. The documentation is clear and the examples very
interesting.
1) For the construction of colors, there is a built in functions "rainbow"
in sage.plot.colors (you can call it with 'rgbtuple' option).
2) You should never use an error catch (try ... except ...) which catches
all errors. The way you did, it would be impossible to send a stop signal
to the process using C-c. You have to write something like
try:
blabla
except TypeError,ValueError:
pass
where the tuple of errors you use is the one which may be raised by the
code in blabla. Errors may be produced from other part of the code and you
should not intercept them!
2') The loop you use for finding a fixed point (actually a periodic point)
is very dirty!! You should be able to compute the smallest k for which
sigma**k(0) starts with 0... For example you can build the substitution
tau which sends alpha to the first letter (or last if reversal) of
sigma(alpha). And then, you can search for a cycle of tau which gives you
periodic points. The best way would be to add a method in WordMorphism
which does it for you... (perhaps an other ticket).
Next to come. If you like I can implement 2') in another ticket ?
Vincent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12454#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
