#12489: Fix equality of combinatorial free module on non totally ordered basis
------------------------------+---------------------------------------------
   Reporter:  hivert          |          Owner:  sage-combinat                  
              
       Type:  defect          |         Status:  needs_work                     
              
   Priority:  critical        |      Milestone:  sage-5.0                       
              
  Component:  combinatorics   |       Keywords:  CombinatorialFreeModule, 
equality, Cernay2012
Work_issues:                  |       Upstream:  N/A                            
              
   Reviewer:  Florent Hivert  |         Author:  Nicolas M. ThiƩry              
              
     Merged:                  |   Dependencies:  #12490                         
              
------------------------------+---------------------------------------------

Comment(by nthiery):

 Replying to [comment:5 jdemeyer]:
 > {{{
 > sage -t --long "devel/sage-main/sage/combinat/sf/dual.py"
 > **********************************************************************
 > File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/devel/sage-
 main/sage/combinat/sf/dual.py", line 33:
 >     sage: TestSuite(f).run()  # long time (11s on sage.math, 2011)
 > Expected nothing
 > Got:
 >     Failure in _test_one:
 >     Traceback (most recent call last):
 >       File
 "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-
 packages/sage/misc/sage_unittest.py", line 275, in run
 >         test_method(tester = tester)
 >       File
 "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-
 packages/sage/categories/monoids.py", line 126, in _tes
 > t_one
 >         tester.assert_(x * one == x)
 >       File
 
"/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python2.7/unittest/case.py",
 line 420, in assertTrue
 >         raise self.failureException(msg)
 >     AssertionError: False is not true
 > [...]
 > }}}

 Thanks for catching that. I am working on it. First thing, I am extracting
 the call to _test_associativity to only set # long on it, and not on the
 full testsuite (otherwise I would have caught the error myself). The other
 thing is that the new equality test highlighted a preexisting bug:
 x*f.one() contains zero coefficients in its dictionary.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12489#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to