#8659: another broken square root simplification
-------------------------+--------------------------------------------------
Reporter: burcin | Owner: burcin
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.0
Component: symbolics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Burcin Erocal
Merged: | Dependencies: #12511
-------------------------+--------------------------------------------------
Changes (by burcin):
* status: needs_work => needs_review
Comment:
Replying to [comment:13 kcrisman]:
> Hmm, that didn't format right. I meant to say, there are two
occurrences of
> {{{
> infite loops
> }}}
I updated the patch to fix the typos.
> I think it would be helpful to have a doctest or two for each branch of
the number field code. Some are no doubt already in there, but all? For
instance, I would have thought that {{{(t^2)^(1/4)}}} is testing {{{return
nbase.power(pexp * exp, hold=True) }}}, but it doesn't give {{{8^(1/2)}}}
like I would have thought from that (so it must be from the {{{if not
SR}}} branch); so it would be good to have one for that branch.
That branch is tested by these:
{{{
sage: sqrt2^(1/5)
2^(1/10)
sage: sqrt2^sqrt2
2^(1/2*sqrt(2))
}}}
> Also, can you think of a place where putting the rational power in the
denominator could cause something to break? Is that standard practice
in this kind of computer algebra? For instance, Maxima does not do this.
> {{{
> (%i3) 2^(-1/2);
> (%o3) 1/sqrt(2)
> }}}
AFAICT, GiNaC assumes this normal form.
On another note... IMHO, a simple typo in comments within source code, or
not documenting which doctest corresponds to which branch in the code is
justification to switch a ticket to `needs_work`. You might not be
satisfied with the work, but it is possible that someone else will give a
positive review, especially since this is a `critical` ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8659#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
