#8659: another broken square root simplification
-------------------------+--------------------------------------------------
   Reporter:  burcin     |          Owner:  burcin       
       Type:  defect     |         Status:  needs_review 
   Priority:  critical   |      Milestone:  sage-5.0     
  Component:  symbolics  |       Keywords:               
Work_issues:             |       Upstream:  N/A          
   Reviewer:             |         Author:  Burcin Erocal
     Merged:             |   Dependencies:  #12511       
-------------------------+--------------------------------------------------

Comment(by kcrisman):

 > On another note... IMHO, a simple typo in comments within source code,
 or not documenting which doctest corresponds to which branch in the code
 is justification to switch a ticket to `needs_work`. You might not be
 satisfied with the work, but it is

 Fair enough!  Though I do think typos are 'needs work', often I can update
 them on a refresh.  The doctest thing was just wanting to check that we
 *did* check all branches.  Maybe 'needs info' is better?  The point is
 that I want to make sure the comment gets seen; a lot of times I see
 questions on 'needs review' that are then never actually addressed.  I
 don't really care what the status itself is.

 > possible that someone else will give a positive review, especially since
 this is a `critical` ticket.

 Well, it's apparently been `critical` for nearly two years, so perhaps
 that is less convincing of an argument on this ticket than others.  But
 point taken in general!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8659#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to