#7766: Upgrade optional spkg valgrind to valgrind-3.7.0
---------------------------------+------------------------------------------
   Reporter:  jsp                |          Owner:  tbd                    
       Type:  enhancement        |         Status:  needs_work             
   Priority:  major              |      Milestone:  sage-5.0               
  Component:  optional packages  |       Keywords:  memory testing         
Work_issues:                     |       Upstream:  N/A                    
   Reviewer:  Jean-Pierre Flori  |         Author:  Jaap Spies, Ivan Andrus
     Merged:                     |   Dependencies:                         
---------------------------------+------------------------------------------
Changes (by jpflori):

  * status:  needs_review => needs_work
  * reviewer:  => Jean-Pierre Flori


Comment:

 I guess that make should be replaced by $MAKE in both spkg-check and spkg-
 install.

 The SAGE_LOCAL logic should also be added to spkg-check.

 Some message should be printed if tests fail.

 The updated changelog in SPKG.txt is wrong (3.6.1 instead of 3.7.0).

 I guess the hg log could contain this ticket number at the beginning
 (#7766: ...)

 Moreover the spkg should be named .... .p0.spkg.

 Otherwise it looks fine.

 I'll test the package now.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7766#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to