#12571: Implementation of shifted shuffle of permutations
------------------------------+---------------------------------------------
Reporter: giraudo | Owner: sage-combinat
Type: enhancement | Status: new
Priority: major | Milestone: sage-5.0
Component: combinatorics | Keywords: Permutations; Shuffle
Work_issues: | Upstream: N/A
Reviewer: Florent Hivert | Author: Samuele Giraudo
Merged: | Dependencies: #12569
------------------------------+---------------------------------------------
Changes (by hivert):
* reviewer: => Florent Hivert
Comment:
Hi Samuele,
Good to have you onboard !
- First of all, if you want a review you should check the {{{needs-
review}}} button below.
- when you put some example under the title {{{EXAMPLES::}}}
there is no need to but them in {{{TESTS::}}}. Both are tested alike.
- You should add a rubric {{{INPUT::}}} explaining what {{{other}}} can
be. Here I think it could be a {{{Permutations}}}, a {{{list}}}, a
{{{tuple}}}
or any {{{iterable}}}. A few examples demonstrating this should also be
added
(see
[http://www.sagemath.org/doc/developer/conventions.html#documentation-
strings documentation strings] for the precise syntax).
- Are you sure that you didn't mixed up the convention for over/under ? To
break the ambiguity, I'd rather call them {{{shifted_concatenation}}} and
{{{shifted_anti_concatenation}}}. Or maybe only one function
{{{shifted_concatenation}}}, with an optional parameter {{{shift}}} which
can
be either {{{"left"}}} or {{{"right"}}}. Or even
{{{shift_right (True by default)}}}...
What do you think ? Maybe it is worth asking for a vote on
{{{Sage-combinat-devel}}}.
- You should add a ".. SEEALSO::" rubric linking the three functions one
to
the other (see also #12078 ;-)
- Finally, You could add some consistency tests checking that for some
relatively large permutations, the cardinality of the interval in the
correct
binomial coefficient.
Sorry for this long list of requests, once you gets used to Sage, you'll
do all
of this without thinking of it.
And many thanks for taking care of this.
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12571#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
