#12579: mechanism to skip self-tests for certain spkgs
------------------------------+---------------------------------------------
   Reporter:  jhpalmieri      |          Owner:  GeorgSWeber  
       Type:  enhancement     |         Status:  needs_work   
   Priority:  minor           |      Milestone:  sage-5.0     
  Component:  build           |       Keywords:               
Work_issues:                  |       Upstream:  N/A          
   Reviewer:  Jeroen Demeyer  |         Author:  John Palmieri
     Merged:                  |   Dependencies:               
------------------------------+---------------------------------------------
Changes (by jdemeyer):

  * status:  needs_review => needs_work
  * reviewer:  => Jeroen Demeyer


Comment:

 Yes, this is more or less what I had in mind.  Two small comments:

 The lines
 {{{
 SAGE_CHECK=no
 export SAGE_CHECK
 }}}
 can be simplified to
 {{{
 export SAGE_CHECK=no
 }}}

 I don't know about the portability of expr, I would use `grep` instead.
 Also you don't want to match "gdmodule" when "gd" is in
 `$SAGE_CHECK_PACKAGES`.  Proposal:
 {{{
 # Allow spaces, commas or colons as separator (the documentation suggests
 commas)
 if echo ",$SAGE_CHECK_PACKAGES," | grep "[ ,:]\!$PKG_BASE[ ,:]"
 >/dev/null; then
     export SAGE_CHECK=no
 elif echo ",$SAGE_CHECK_PACKAGES," | grep "[ ,:]$PKG_BASE[ ,:]"
 >/dev/null; then
     export SAGE_CHECK=yes
 fi
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12579#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to