#7071: palp spkg ignores global CC and CFLAGS variables
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: build | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Volker Braun | Author: R. Andrew Ohana
Merged: | Dependencies: #12055
----------------------------+-----------------------------------------------
Comment(by drkirkby):
Replying to [comment:2 mjo]:
> Can we pass CFLAGS, too? That will allow us to get rid of that horrible
`sed`. Might as well fix the "xyes" test also
The "xyes" test, as it is called above, is the safest, most portable way
to test for a string, as other methods, like the proposed change, can fail
under obscure conditions. One might argue they don't fail with modern
versions of bash, but IMHO is it worthwhile to write scripts which will
always work under all conditions. The original code will always work - the
proposed change is less portable. I suggest you take a look at the scripts
created by autoconf. You will find they use a similar method to what was
in Sage, as it is known to always work.
As such, I believe the change is a retrograde step.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7071#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
