#7071: palp spkg ignores global CC and CFLAGS variables
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: build | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Volker Braun | Author: R. Andrew Ohana
Merged: | Dependencies: #12055
----------------------------+-----------------------------------------------
Changes (by vbraun):
* status: needs_work => positive_review
Comment:
I disagree. The xblah test makes it more difficult to read the test, which
both increases the chance for errors as well as the long-term maintenance
effort.
A quick survey shows that at least half of the Sage spkgs use the
simplified test, so clearly nobody has yet encountered a shell ancient
enough to not work. I'm pretty sure many upstream sources use simplified
tests, too, so there is basically no hope of ever compiling Sage on such a
system without installing a shell that isn't from the middle ages.
Autotools output really is a totally different issue, since their scripts
are autogenerated readability is not an issue (and usually is pretty bad,
in fact).
If you disagree we can discuss this on the sage-devel, but its such a
pervasive issue throughout Sage that it doesn't really matter if we use
the simplified test in one spkg more or less.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7071#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
