#11790: `sage --sh -c ...` shouldn't print [that many] messages
---------------------------------------------+------------------------------
Reporter: leif | Owner:
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-5.0
Component: scripts | Keywords: subshell
commands sage-sage environment batch mode stdout
Work_issues: | Upstream: N/A
Reviewer: Jeroen Demeyer, John Palmieri | Author: John Palmieri,
Jeroen Demeyer
Merged: | Dependencies: #12647
---------------------------------------------+------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: Jeroen Demeyer => Jeroen Demeyer, John Palmieri
* author: John Palmieri => John Palmieri, Jeroen Demeyer
Comment:
This looks good to me.
Regarding the use of "exec", which was suggested by Leif, was in my
version of the patch, and is in the current patch: if we want to be able
to do something like `sage --norc -c ...` (as in #11932), then we want to
be able to delete the temporary `DOTSAGE` directory after the Sage command
finishes. Using "exec" prevents this, doesn't it? So unless I'm
misunderstanding and there is a good way to clean things up after "exec
CMD", we should be wary of overusing "exec" in the sage script.
Anyway, I'm willing to give this a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11790#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
