#11874: Remove twisted spkg
----------------------------------------------+-----------------------------
Reporter: dimpase | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: twisted;
notebook
Work_issues: | Upstream: N/A
Reviewer: Dmitrii Pasechnik, Jason Grout | Author: Rado Kirov,
Jason Grout
Merged: | Dependencies: #12329, #11080
----------------------------------------------+-----------------------------
Changes (by dimpase):
* status: needs_work => needs_review
Comment:
Replying to [comment:54 jdemeyer]:
> It needs some more documentation though, this should be expanded a bit:
Done.
> Also you should follow the format of
[http://sagemath.org/doc/developer/conventions.html#headings-of-sage-
library-code-files] (without the `EXAMPLES`). Mention this ticket.
This file is NOT a part of Sage library code. It's basically a part of
setup.py, and I followed the informal style we use for this kind of stuff
(I could have inserted this code into the setup.py directly, but I felt
it's cleaner to keep it separate)
>
> I'm also not too happy with the name "fpickl.py". It sounds too much
like a typo. What about "fpickle_setup.py" or something?
Duly renamed as you suggested. The updated patch is uploaded, ready for
review again.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11874#comment:55>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
