#11874: Remove twisted spkg
----------------------------------------------+-----------------------------
Reporter: dimpase | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: twisted;
notebook
Work_issues: | Upstream: N/A
Reviewer: Dmitrii Pasechnik, Jason Grout | Author: Rado Kirov,
Jason Grout
Merged: | Dependencies: #12329, #11080
----------------------------------------------+-----------------------------
Comment(by dimpase):
Replying to [comment:61 ppurka]:
> Replying to [comment:60 dimpase]:
> > applying the patches etc procedure for this ticket, and then #11080,
followed by ptestlong, shows one failing doctest, in sagenb (which is just
very outdated code in sagenb, as the current Poset has more keyargs than
expected by the test).
> > This needs to be fixed in sagenb, not here.
>
> This is already
[https://github.com/sagemath/sagenb/commit/a6e1f2103880434b5f48c41d7c157cfdae9cc110
fixed "upstream"]. :)
"upstream", please remove twisted 11 from sagenb! Indeed, after all this
is installed I see:
{{{
sage: import twisted
sage: twisted.version
Version('twisted', 12, 0, 0)
}}}
fair enough, the installation log of sagenb-0.9.0 spkg (see #11080) has
the following lines:
{{{
...
Searching for Flask==0.8
Best match: Flask 0.8
Processing Flask-0.8-py2.7.egg
Flask 0.8 is already the active version in easy-install.pth
Using /usr/local/src/sage/sage-5.0.beta8/local/lib/python2.7/site-
packages/Flask-0.8-py2.7.egg
Searching for Twisted==12.0.0
Best match: Twisted 12.0.0
Processing Twisted-12.0.0-py2.7-macosx-10.6-x86_64.egg
Removing Twisted 11.1.0 from easy-install.pth file
Adding Twisted 12.0.0 to easy-install.pth file
...
}}}
so Twisted 11.1.0 need not be bundled, and in fact I suspect that many
installations of Sage that are thought of running twisted 11 are actually
running twisted 12!
Thus, either remove twisted 11 from the sagenb bundle, or keep it (if
there areny reasons?) and make sure that it gets used!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11874#comment:62>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.