#12662: Improve doctest coverage for sage.rings.qqbar
----------------------------------+-----------------------------------------
Reporter: davidloeffler | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: David Loeffler | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by JStarx):
The functions `gen`, `gens`, and `ngens` override methods from
`ParentWithGens` and `_is_valid_homomorphism_` overrides a method from
`Parent`. If you don't override them then calling them will return a
`NotImplementedError` which doesn't seem wise as they are used, for
example `_is_valid_homomorphism_` is called by the init method of
`RingHomomorphism_im_gens`.
Also I do think they make mathematical sense. A field is generated by a
single element, the 1 of the field, and for a homomorphism of fields we
must send 1 to 1.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12662#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
