#9894: Group cohomology spkg, version 2.1.2
-------------------------------------------------------+--------------------
       Reporter:  SimonKing                            |         Owner:         
                           
           Type:  enhancement                          |        Status:  
positive_review                   
       Priority:  major                                |     Milestone:  
sage-5.0                          
      Component:  optional packages                    |    Resolution:         
                           
       Keywords:  modular group cohomology solaris t2  |   Work issues:         
                           
Report Upstream:  N/A                                  |     Reviewers:  
Karl-Dieter Crisman, John Palmieri
        Authors:  Simon King                           |     Merged in:         
                           
   Dependencies:                                       |      Stopgaps:         
                           
-------------------------------------------------------+--------------------
Changes (by jhpalmieri):

  * status:  needs_review => positive_review
  * reviewer:  Karl-Dieter Crisman => Karl-Dieter Crisman, John Palmieri


Comment:

 This looks great! Positive review. I appreciate having the documentation
 locally, too.

 At least one thing which ought to be easy to implement in a future
 version: `additive_order` for elements: `a.additive_order()` should be
 either `1` (if `a==0`) or `p` (the characteristic of the ground field. If
 you ever construct cohomology rings over non-fields, you could leave it
 unimplemented in that case.

 I found this a little strange:
 {{{
 sage: H0 = CohomologyRing(8,3)
 sage: (H0.2 * H0.3).is_zero()
 True
 sage: (H0.2 * H0.3) == 0
 False
 }}}
 Maybe comparisons or `__eq__` need to be implemented, too.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9894#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to