#12112: Update the prereq script
-------------------------------------------------+--------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Jeroen
Demeyer, David Kirkby
Authors: John Palmieri, Jeroen Demeyer | Merged in:
Dependencies: #12739 | Stopgaps:
-------------------------------------------------+--------------------------
Changes (by drkirkby):
* reviewer: Jeroen Demeyer => Jeroen Demeyer, David Kirkby
Comment:
A few comments:
1) Testing with:
{{{
if [ "$SAGE_BUILD_DIR" = "" ]; then
}}}
is bad practice. Testing on "" can fail under some admittedly obscure
circumstances. Better would be
{{{
if [ "x$SAGE_BUILD_DIR" = x ]; then
}}}
2) Are we 100% sure m4 is not needed? I have some recollection of it being
needed somewhere. If not, this
http://www.sagemath.org/doc/faq/faq-usage.html
needs modifying, as that specifically says to install m4. The configure
script was clearly written with this in mind too.
I can't judge all the implications of all the changes, but looking at the
diffs only, I can't see anything that looks as though it will be a
problem.
A couple of minor points, one could address if one wanted to:
a) The Solaris page should now really be to Oracle and not Sun, but it's
no big deal.
b) Although William was annoyed when Sage would not build with gcc 3.4
series due to "ratpoints", and was keen to get Sage working with gcc
3.4.x, I think the chances of that happening are very remote now. There is
too much code that will not compile with such an old version of gcc. So
one could consider removing all the checks associated with gcc 3.4.x, and
simply accept that gcc 4.0.1 is the minimum version. That could take quite
a bit of code out, and would mean that SAGE_USE_OLD_GCC could be removed
from the list of environment variables.
So I can't see anything wrong, with the exception of how SAGE_BUILD_DIR is
tested.
Assuming John and Jeroen are happy with each others changes, and the
SAGE_BUILD_DIR issue is fixed, I think this should be set to positive
review.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12112#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
