#11943: The category graph should comply with Python's method resolution order
-----------------------------------------------------------+----------------
Reporter: SimonKing | Owner:
nthiery
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.0
Component: categories | Resolution:
Keywords: category graph, method resolution order | Work issues:
rebase
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: #11900, #7980 | Stopgaps:
-----------------------------------------------------------+----------------
Comment (by nthiery):
Hi Simon,
I have finished my review. I'll push shortly my reviewer's patch on the
Sage-Combinat queue
http://combinat.sagemath.org/patches/file/tip
/trac11943_mro_for_all_super_categories_lazy_hook-review-nt.patch
Overall, I am happy with it, and it's almost good to go if you are happy
with my changes. Thanks for your hard work!
Just two little details:
* in covariant_functorial_construction.py, the method is_subcategory is
not documented, and I am not sure why it is required. Please remove, or
add documentation and tests with a comment on the rationale for this
method
* in the C3 algorithm: Cython knows that ``tails`` is a list, so one would
assume that tails[i] is optimized. Is it really faster to use
PyList_GET_ITEM(tails,i) rather than just tails[i]? Otherwise, please use
the later which is more readable. Same thing for the other PyList_*.
Once those are done, and it is confirmed that all tests pass (I am running
them), you can set a positive review on my behalf (I'll be away for the
week-end).
Happy easter!
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11943#comment:80>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
