#12812: Bug in summation of toric divisors
--------------------------------------+-------------------------------------
       Reporter:  novoselt            |         Owner:  AlexGhitza
           Type:  defect              |        Status:  new       
       Priority:  major               |     Milestone:  sage-5.0  
      Component:  algebraic geometry  |    Resolution:            
       Keywords:                      |   Work issues:            
Report Upstream:  N/A                 |     Reviewers:            
        Authors:                      |     Merged in:            
   Dependencies:                      |      Stopgaps:            
--------------------------------------+-------------------------------------

Comment (by novoselt):

 Hi Volker,

 I looked through the code and a possible solution is to catch integers in
 `_element_constructor_` of `ToricDivisorGroup` instead of passing them
 down to `ToricDivisor`. "Catch" means replace 0 with `None` to construct
 the trivial divisor and raise an exception for anything else.

 It is not very elegant, but keeps current functionality and `X.divisor(i)`
 returning the divisor of the i-th ray still seems quite reasonable to me,
 while `X.divisor_group()(i)` is questionable.

 If you agree, I'll make the change and try to make it clear in the
 documentation of all the methods involved.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12812#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to